diff options
author | Cosmin Ratiu <cratiu@nvidia.com> | 2024-10-31 15:58:52 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2024-11-04 02:37:14 +0300 |
commit | cac7356c653d1410838209b6e840a705898d1811 (patch) | |
tree | 32993b7f552130709a4b202b5afeaae5d4d84c59 /tools/perf/scripts/python/task-analyzer.py | |
parent | 9ff75a23dff3622451057b2ccd88c19bbb293841 (diff) | |
download | linux-cac7356c653d1410838209b6e840a705898d1811.tar.xz |
net/mlx5: Rework esw qos domain init and cleanup
The first approach was flawed, because there are situations where the
esw mode change fails, leaving the qos domain as NULL. Various calls
into the QoS infra then trigger a NULL pointer access and unhappiness.
Improve that by a combination of:
- Allocating the QoS domain on esw init and cleaning it up on teardown.
- Refactoring mode change to only call qos domain init but not cleanup.
- Making qos domain init idempotent - not change anything if nothing
needs changing.
Together, these should guarantee that, as long as the memory allocations
succeed, there should always be a valid qos domain until the esw
cleanup, no matter what mode changes happen (or failures thereof).
Fixes: 107a034d5c1e ("net/mlx5: qos: Store rate groups in a qos domain")
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20241031125856.530927-2-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/task-analyzer.py')
0 files changed, 0 insertions, 0 deletions