diff options
author | Stanislav Spassov <stanspas@amazon.de> | 2025-02-18 17:10:45 +0300 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2025-02-21 16:47:26 +0300 |
commit | 1937e18cc3cf27e2b3ef70e8c161437051ab7608 (patch) | |
tree | 3e91975f4a0553e72386dcdc60bd2b270e8b7fcd /tools/perf/scripts/python/task-analyzer.py | |
parent | ccb7735a1ea22621f21c3133e4f5f3da5fe5f5b7 (diff) | |
download | linux-1937e18cc3cf27e2b3ef70e8c161437051ab7608.tar.xz |
x86/fpu: Fix guest FPU state buffer allocation size
Ongoing work on an optimization to batch-preallocate vCPU state buffers
for KVM revealed a mismatch between the allocation sizes used in
fpu_alloc_guest_fpstate() and fpstate_realloc(). While the former
allocates a buffer sized to fit the default set of XSAVE features
in UABI form (as per fpu_user_cfg), the latter uses its ksize argument
derived (for the requested set of features) in the same way as the sizes
found in fpu_kernel_cfg, i.e. using the compacted in-kernel
representation.
The correct size to use for guest FPU state should indeed be the
kernel one as seen in fpstate_realloc(). The original issue likely
went unnoticed through a combination of UABI size typically being
larger than or equal to kernel size, and/or both amounting to the
same number of allocated 4K pages.
Fixes: 69f6ed1d14c6 ("x86/fpu: Provide infrastructure for KVM FPU cleanup")
Signed-off-by: Stanislav Spassov <stanspas@amazon.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20250218141045.85201-1-stanspas@amazon.de
Diffstat (limited to 'tools/perf/scripts/python/task-analyzer.py')
0 files changed, 0 insertions, 0 deletions