diff options
| author | Shubhrajyoti D <shubhrajyoti@ti.com> | 2012-05-29 14:56:16 +0400 |
|---|---|---|
| committer | Wolfram Sang <w.sang@pengutronix.de> | 2012-07-08 14:49:13 +0400 |
| commit | 62ff2c2b1a36de9dd98e9b8a575da6e6b2365740 (patch) | |
| tree | 2906cd9374c664eca6853fdb95b6bdc364e4164e /tools/perf/scripts/python/syscall-counts-by-pid.py | |
| parent | bd16c82f67a267b533e747c74c2fcd23578d4601 (diff) | |
| download | linux-62ff2c2b1a36de9dd98e9b8a575da6e6b2365740.tar.xz | |
I2C: OMAP: Prevent the register access after pm_runtime_put in probe
Currently in probe
pm_runtime_put(dev->dev);
...
/* i2c device drivers may be active on return from add_adapter() */
adap->nr = pdev->id;
r = i2c_add_numbered_adapter(adap);
if (r) {
dev_err(dev->dev, "failure adding adapter\n");
goto err_free_irq;
}
...
return 0;
err_free_irq:
free_irq(dev->irq, dev);
err_unuse_clocks:
omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, 0);
pm_runtime_put(dev->dev);
This may access the i2c registers without the clocks in the error cases.
Fix the same by moving the pm_runtime_put after the error check.
Reviewed-by: Kevin Hilman <khilman@ti.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Diffstat (limited to 'tools/perf/scripts/python/syscall-counts-by-pid.py')
0 files changed, 0 insertions, 0 deletions
