diff options
author | Nikolay Aleksandrov <razor@blackwall.org> | 2025-02-27 19:41:29 +0300 |
---|---|---|
committer | Paolo Abeni <pabeni@redhat.com> | 2025-03-04 13:14:15 +0300 |
commit | 1a82d19ca2d6835904ee71e2d40fd331098f94a0 (patch) | |
tree | 45c97c67625405abdb3c06191b8b74d7b5e2564b /tools/perf/scripts/python/stackcollapse.py | |
parent | 64e6a754d33d31aa844b3ee66fb93ac84ca1565e (diff) | |
download | linux-1a82d19ca2d6835904ee71e2d40fd331098f94a0.tar.xz |
be2net: fix sleeping while atomic bugs in be_ndo_bridge_getlink
Partially revert commit b71724147e73 ("be2net: replace polling with
sleeping in the FW completion path") w.r.t mcc mutex it introduces and the
use of usleep_range. The be2net be_ndo_bridge_getlink() callback is
called with rcu_read_lock, so this code has been broken for a long time.
Both the mutex_lock and the usleep_range can cause the issue Ian Kumlien
reported[1]. The call path is:
be_ndo_bridge_getlink -> be_cmd_get_hsw_config -> be_mcc_notify_wait ->
be_mcc_wait_compl -> usleep_range()
[1] https://lore.kernel.org/netdev/CAA85sZveppNgEVa_FD+qhOMtG_AavK9_mFiU+jWrMtXmwqefGA@mail.gmail.com/
Tested-by: Ian Kumlien <ian.kumlien@gmail.com>
Fixes: b71724147e73 ("be2net: replace polling with sleeping in the FW completion path")
Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
Link: https://patch.msgid.link/20250227164129.1201164-1-razor@blackwall.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'tools/perf/scripts/python/stackcollapse.py')
0 files changed, 0 insertions, 0 deletions