diff options
author | Cong Wang <xiyou.wangcong@gmail.com> | 2025-03-07 02:23:54 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2025-03-12 22:51:58 +0300 |
commit | 0c3057a5a04d07120b3d0ec9c79568fceb9c921e (patch) | |
tree | 182186645ee082560be958b0a097d35855fadde3 /tools/perf/scripts/python/sched-migration.py | |
parent | 081b575617e6f9355edf054cb907bdb8af7ed149 (diff) | |
download | linux-0c3057a5a04d07120b3d0ec9c79568fceb9c921e.tar.xz |
net_sched: Prevent creation of classes with TC_H_ROOT
The function qdisc_tree_reduce_backlog() uses TC_H_ROOT as a termination
condition when traversing up the qdisc tree to update parent backlog
counters. However, if a class is created with classid TC_H_ROOT, the
traversal terminates prematurely at this class instead of reaching the
actual root qdisc, causing parent statistics to be incorrectly maintained.
In case of DRR, this could lead to a crash as reported by Mingi Cho.
Prevent the creation of any Qdisc class with classid TC_H_ROOT
(0xFFFFFFFF) across all qdisc types, as suggested by Jamal.
Reported-by: Mingi Cho <mincho@theori.io>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Fixes: 066a3b5b2346 ("[NET_SCHED] sch_api: fix qdisc_tree_decrease_qlen() loop")
Link: https://patch.msgid.link/20250306232355.93864-2-xiyou.wangcong@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/sched-migration.py')
0 files changed, 0 insertions, 0 deletions