diff options
author | Kevin Hao <haokexin@gmail.com> | 2025-04-10 09:56:09 +0300 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2025-04-10 14:25:20 +0300 |
commit | 5d07ab2a7fa1305e429d9221716582f290b58078 (patch) | |
tree | 191e1007554e9ba262e8a5221176019451ab173c /tools/perf/scripts/python/failed-syscalls-by-pid.py | |
parent | 0af2f6be1b4281385b618cb86ad946eded089ac8 (diff) | |
download | linux-5d07ab2a7fa1305e429d9221716582f290b58078.tar.xz |
spi: fsl-qspi: Fix double cleanup in probe error path
Commit 40369bfe717e ("spi: fsl-qspi: use devm function instead of driver
remove") introduced managed cleanup via fsl_qspi_cleanup(), but
incorrectly retain manual cleanup in two scenarios:
- On devm_add_action_or_reset() failure, the function automatically call
fsl_qspi_cleanup(). However, the current code still jumps to
err_destroy_mutex, repeating cleanup.
- After the fsl_qspi_cleanup() action is added successfully, there is no
need to manually perform the cleanup in the subsequent error path.
However, the current code still jumps to err_destroy_mutex on spi
controller failure, repeating cleanup.
Skip redundant manual cleanup calls to fix these issues.
Cc: stable@vger.kernel.org
Fixes: 40369bfe717e ("spi: fsl-qspi: use devm function instead of driver remove")
Signed-off-by: Kevin Hao <haokexin@gmail.com>
Link: https://patch.msgid.link/20250410-spi-v1-1-56e867cc19cf@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/failed-syscalls-by-pid.py')
0 files changed, 0 insertions, 0 deletions