diff options
author | Javier Martinez Canillas <javierm@redhat.com> | 2022-05-06 01:05:40 +0300 |
---|---|---|
committer | Javier Martinez Canillas <javierm@redhat.com> | 2022-05-06 10:21:22 +0300 |
commit | d258d00fb9c7c0cdf9d10c1ded84f10339d2d349 (patch) | |
tree | 8bc8c745a09b79b90b27fb8b7313c9cd4e57cdad /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | 666b90b3ce9e4aac1e1deba266c3a230fb3913b0 (diff) | |
download | linux-d258d00fb9c7c0cdf9d10c1ded84f10339d2d349.tar.xz |
fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove
The driver is calling framebuffer_release() in its .remove callback, but
this will cause the struct fb_info to be freed too early. Since it could
be that a reference is still hold to it if user-space opened the fbdev.
This would lead to a use-after-free error if the framebuffer device was
unregistered but later a user-space process tries to close the fbdev fd.
To prevent this, move the framebuffer_release() call to fb_ops.fb_destroy
instead of doing it in the driver's .remove callback.
Strictly speaking, the code flow in the driver is still wrong because all
the hardware cleanupd (i.e: iounmap) should be done in .remove while the
software cleanup (i.e: releasing the framebuffer) should be done in the
.fb_destroy handler. But this at least makes to match the behavior before
commit 27599aacbaef ("fbdev: Hot-unplug firmware fb devices on forced removal").
Fixes: 27599aacbaef ("fbdev: Hot-unplug firmware fb devices on forced removal")
Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220505220540.366218-1-javierm@redhat.com
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions