diff options
author | Johan Hovold <johan@kernel.org> | 2021-05-24 14:09:18 +0300 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-06-02 15:14:16 +0300 |
commit | 8ed339f23d41e21660a389adf2e7b2966d457ff6 (patch) | |
tree | 8817450989490d176c4bffdf4da33d8d3bec04c6 /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | 5eabfbdd7d6a473afbbd4916877ee04801ca2c45 (diff) | |
download | linux-8ed339f23d41e21660a389adf2e7b2966d457ff6.tar.xz |
media: gspca/gl860: fix zero-length control requests
The direction of the pipe argument must match the request-type direction
bit or control requests may fail depending on the host-controller-driver
implementation.
Control transfers without a data stage are treated as OUT requests by
the USB stack and should be using usb_sndctrlpipe(). Failing to do so
will now trigger a warning.
Fix the gl860_RTx() helper so that zero-length control reads fail with
an error message instead. Note that there are no current callers that
would trigger this.
Fixes: 4f7cb8837cec ("V4L/DVB (12954): gspca - gl860: Addition of GL860 based webcams")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions