diff options
author | Reinette Chatre <reinette.chatre@intel.com> | 2024-10-25 00:18:42 +0300 |
---|---|---|
committer | Shuah Khan <skhan@linuxfoundation.org> | 2024-11-05 03:02:02 +0300 |
commit | 46058430fc5d39c114f7e1b9c6ff14c9f41bd531 (patch) | |
tree | 3d05e948e25c50a5174ef2e8480c9fc019d63b8f /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | 48ed4e799e8fbebae838dca404a8527763d41191 (diff) | |
download | linux-46058430fc5d39c114f7e1b9c6ff14c9f41bd531.tar.xz |
selftests/resctrl: Protect against array overflow when reading strings
resctrl selftests discover system properties via a variety of sysfs files.
The MBM and MBA tests need to discover the event and umask with which to
configure the performance event used to measure read memory bandwidth.
This is done by parsing the contents of
/sys/bus/event_source/devices/uncore_imc_<imc instance>/events/cas_count_read
Similarly, the resctrl selftests discover the cache size via
/sys/bus/cpu/devices/cpu<id>/cache/index<index>/size.
Take care to do bounds checking when using fscanf() to read the
contents of files into a string buffer because by default fscanf() assumes
arbitrarily long strings. If the file contains more bytes than the array
can accommodate then an overflow will occur.
Provide a maximum field width to the conversion specifier to protect
against array overflow. The maximum is one less than the array size because
string input stores a terminating null byte that is not covered by the
maximum field width.
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions