diff options
author | Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> | 2024-12-09 17:27:57 +0300 |
---|---|---|
committer | Bjorn Andersson <andersson@kernel.org> | 2025-01-07 03:36:59 +0300 |
commit | 1e76b546e6fca7eb568161f408133904ca6bcf4f (patch) | |
tree | 6aeb48975bca0fc260e12642f114d2191f18dbaf /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | b628510397b5cafa1f5d3e848a28affd1c635302 (diff) | |
download | linux-1e76b546e6fca7eb568161f408133904ca6bcf4f.tar.xz |
firmware: qcom: scm: Cleanup global '__scm' on probe failures
If SCM driver fails the probe, it should not leave global '__scm'
variable assigned, because external users of this driver will assume the
probe finished successfully. For example TZMEM parts ('__scm->mempool')
are initialized later in the probe, but users of it (__scm_smc_call())
rely on the '__scm' variable.
This fixes theoretical NULL pointer exception, triggered via introducing
probe deferral in SCM driver with call trace:
qcom_tzmem_alloc+0x70/0x1ac (P)
qcom_tzmem_alloc+0x64/0x1ac (L)
qcom_scm_assign_mem+0x78/0x194
qcom_rmtfs_mem_probe+0x2d4/0x38c
platform_probe+0x68/0xc8
Fixes: 40289e35ca52 ("firmware: qcom: scm: enable the TZ mem allocator")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20241209-qcom-scm-missing-barriers-and-all-sort-of-srap-v2-4-9061013c8d92@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions