diff options
| author | Michael Zaidman <michael.zaidman@gmail.com> | 2022-11-06 00:11:39 +0300 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2022-11-11 13:09:35 +0300 |
| commit | f45d50ede6f9e6d76a218e6ed06cc352acad466f (patch) | |
| tree | 714a4c09729662cd277ec643e353c5301cfbb4d0 /tools/perf/scripts/python/export-to-postgresql.py | |
| parent | 334fe5d3a99aea2e92b934b4c58fffee9b056c5d (diff) | |
| download | linux-f45d50ede6f9e6d76a218e6ed06cc352acad466f.tar.xz | |
HID: ft260: ft260_xfer_status routine cleanup
After clarifying with FTDI's support, it turned out that the error
condition (bit 1) in byte 1 of the i2c status HID report is a status
bit reflecting all error conditions. When bits 2, 3, or 4 are raised
to 1, bit 1 is set to 1 also. Since the ft260_xfer_status routine tests
the error condition bit and exits in the case of an error, the program
flow never reaches the conditional expressions for 2, 3, and 4 bits when
any of them indicates an error state. Though these expressions are never
evaluated to true, they are checked several times per IO, increasing the
ft260_xfer_status polling cycle duration.
The patch removes the conditional expressions for 2, 3, and 4 bits in
byte 1 of the i2c status HID report.
Signed-off-by: Michael Zaidman <michael.zaidman@gmail.com>
Tested-by: Guillaume Champagne <champagne.guillaume.c@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions