diff options
author | Jeff Johnson <quic_jjohnson@quicinc.com> | 2024-11-19 18:47:38 +0300 |
---|---|---|
committer | Jeff Johnson <quic_jjohnson@quicinc.com> | 2024-11-21 18:59:34 +0300 |
commit | 8ea1d2072ad1a9c24b326b50ebdc2c810c4b2cce (patch) | |
tree | cdd4086cb6eb5bee09c31a16e755bde3120ad6fd /tools/perf/scripts/python/export-to-postgresql.py | |
parent | 47c7ebfba30f242a24a89317c74eada47adfaa95 (diff) | |
download | linux-8ea1d2072ad1a9c24b326b50ebdc2c810c4b2cce.tar.xz |
wifi: ath11k: mark some QMI driver event helpers as noinline
When compiling the ath11k driver using clang with KASAN enabled, the
following warning is observed:
drivers/net/wireless/ath/ath11k/qmi.c:3199:13: warning: stack frame size (1560) exceeds limit (1024) in 'ath11k_qmi_driver_event_work' [-Wframe-larger-than]
This is similar to the issue found in ath12k/qmi.c that was discussed
in [1] and fixed with [2]. The issue is that clang inlining can
explode stack usage.
Just as in ath12k, ath11k_qmi_driver_event_work() itself is a pretty
lightweight function, but it dispatches to several other functions
which do the real work:
ath11k_qmi_driver_event_work()
ath11k_qmi_event_server_arrive()
ath11k_qmi_fw_ind_register_send()
ath11k_qmi_host_cap_send() *
ath11k_qmi_event_load_bdf()
ath11k_qmi_event_mem_request()
ath11k_qmi_respond_fw_mem_request()
ath11k_qmi_event_load_bdf()
ath11k_qmi_wlanfw_m3_info_send() *
ath11k_qmi_m3_load()
ath11k_qmi_process_coldboot_calibration()
Of these, the two marked with * have non-trivial stack usage. Mark
those functions as 'noinline_for_stack' to prevent them from being
inlined in ath12k_qmi_driver_event_work(), thereby eliminating the
excessive stack usage.
Note that this approach is a bit more "surgical" than the ath12k
approach as only the two functions with the largest stack usage are
modified.
Compile tested only.
Link: https://msgid.link/bc214795-1c51-4cb7-922f-67d6ef98bff2@quicinc.com # [1]
Link: https://patch.msgid.link/20241028-ath12k_qmi_driver_event_work-v1-1-0d532eb593fa@quicinc.com # [2]
Acked-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20241119-ath11k-noinline-v1-1-4ec0a8aa30b2@quicinc.com
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions