diff options
author | Chuyi Zhou <zhouchuyi@bytedance.com> | 2025-02-12 16:09:35 +0300 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2025-02-13 19:57:33 +0300 |
commit | f5717c93a1b999970f3a64d771a1a9ee68cc37d0 (patch) | |
tree | 7472bc84549f8f52fc69bd8f7e086ce4d188ba32 /tools/perf/scripts/python/arm-cs-trace-disasm.py | |
parent | 2e2006c91c842c551521434466f9b4324719c9a7 (diff) | |
download | linux-f5717c93a1b999970f3a64d771a1a9ee68cc37d0.tar.xz |
sched_ext: Use SCX_CALL_OP_TASK in task_tick_scx
Now when we use scx_bpf_task_cgroup() in ops.tick() to get the cgroup of
the current task, the following error will occur:
scx_foo[3795244] triggered exit kind 1024:
runtime error (called on a task not being operated on)
The reason is that we are using SCX_CALL_OP() instead of SCX_CALL_OP_TASK()
when calling ops.tick(), which triggers the error during the subsequent
scx_kf_allowed_on_arg_tasks() check.
SCX_CALL_OP_TASK() was first introduced in commit 36454023f50b ("sched_ext:
Track tasks that are subjects of the in-flight SCX operation") to ensure
task's rq lock is held when accessing task's sched_group. Since ops.tick()
is marked as SCX_KF_TERMINAL and task_tick_scx() is protected by the rq
lock, we can use SCX_CALL_OP_TASK() to avoid the above issue. Similarly,
the same changes should be made for ops.disable() and ops.exit_task(), as
they are also protected by task_rq_lock() and it's safe to access the
task's task_group.
Fixes: 36454023f50b ("sched_ext: Track tasks that are subjects of the in-flight SCX operation")
Signed-off-by: Chuyi Zhou <zhouchuyi@bytedance.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/arm-cs-trace-disasm.py')
0 files changed, 0 insertions, 0 deletions