diff options
| author | Ian Rogers <irogers@google.com> | 2025-08-23 03:00:24 +0300 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2025-08-26 01:07:18 +0300 |
| commit | 2c369d91d0933aaff96b6b807b22363e6a38a625 (patch) | |
| tree | e22a6006aa6771373c892470e3516da2e2292404 /tools/perf/bench | |
| parent | ba0b7081f7a521d7c28b527a4f18666a148471e7 (diff) | |
| download | linux-2c369d91d0933aaff96b6b807b22363e6a38a625.tar.xz | |
perf symbol: Add blocking argument to filename__read_build_id
When synthesizing build-ids, for build ID mmap2 events, they will be
added for data mmaps if -d/--data is specified. The files opened for
their build IDs may block on the open causing perf to hang during
synthesis. There is some robustness in existing calls to
filename__read_build_id by checking the file path is to a regular
file, which unfortunately fails for symlinks. Rather than adding more
is_regular_file calls, switch filename__read_build_id to take a
"block" argument and specify O_NONBLOCK when this is false. The
existing is_regular_file checking callers and the event synthesis
callers are made to pass false and thereby avoiding the hang.
Fixes: 53b00ff358dc ("perf record: Make --buildid-mmap the default")
Signed-off-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250823000024.724394-3-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf/bench')
| -rw-r--r-- | tools/perf/bench/inject-buildid.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/bench/inject-buildid.c b/tools/perf/bench/inject-buildid.c index aad572a78d7f..12387ea88b9a 100644 --- a/tools/perf/bench/inject-buildid.c +++ b/tools/perf/bench/inject-buildid.c @@ -85,7 +85,7 @@ static int add_dso(const char *fpath, const struct stat *sb __maybe_unused, if (typeflag == FTW_D || typeflag == FTW_SL) return 0; - if (filename__read_build_id(fpath, &bid) < 0) + if (filename__read_build_id(fpath, &bid, /*block=*/true) < 0) return 0; dso->name = realpath(fpath, NULL); |