summaryrefslogtreecommitdiff
path: root/tools/lib/python/__init__.py
diff options
context:
space:
mode:
authorJakub Kicinski <kuba@kernel.org>2026-05-10 22:29:00 +0300
committerPaolo Abeni <pabeni@redhat.com>2026-05-12 17:14:59 +0300
commit0f9a857e34d0f8c018a3e4435c6f0e92e8d2f38c (patch)
tree3738c91b6ba7a2673ce6a8649c486bdf593dcf45 /tools/lib/python/__init__.py
parent8054f85b83f42a37d482fc77ea7c9ff06a9407d9 (diff)
downloadlinux-0f9a857e34d0f8c018a3e4435c6f0e92e8d2f38c.tar.xz
net: shaper: fix undersized reply skb allocation in GROUP command
net_shaper_group_send_reply() writes both the NET_SHAPER_A_IFINDEX attribute (via net_shaper_fill_binding()) and the nested NET_SHAPER_A_HANDLE attribute (via net_shaper_fill_handle()), but the reply skb at the call site in net_shaper_nl_group_doit() is allocated using net_shaper_handle_size(), which only accounts for the nested handle. The allocation is therefore short by nla_total_size(sizeof(u32)) (8 bytes) for the IFINDEX attribute. In practice the slab allocator rounds up the small allocation so the bug is latent, but the size accounting is wrong and could bite if the reply grew further. Introduce net_shaper_group_reply_size() that accounts for the full reply payload and use it both at the genlmsg_new() call site and in the defensive WARN_ONCE message. Fixes: 5d5d4700e75d ("net-shapers: implement NL group operation") Signed-off-by: Jakub Kicinski <kuba@kernel.org> Link: https://patch.msgid.link/20260510192904.3987113-7-kuba@kernel.org Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'tools/lib/python/__init__.py')
0 files changed, 0 insertions, 0 deletions