diff options
| author | Jaska Uimonen <jaska.uimonen@linux.intel.com> | 2021-05-19 13:07:13 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-05-20 19:57:28 +0300 |
| commit | b9c035aa43b8c074b3bcfdaaa8bea2537d85b7c3 (patch) | |
| tree | f58459bee23394ababd7e74d9b0aec17e8fdfae7 /sound/soc/soc-topology.c | |
| parent | 60339074c4e4445312c7b60b16035cfbd8914e58 (diff) | |
| download | linux-b9c035aa43b8c074b3bcfdaaa8bea2537d85b7c3.tar.xz | |
ASoC: topology: Fix using uninitialized pointer
The original patch changed kcontrol_type to a pointer. In some goto
cases the pointer is assigned into a struct member as uninitialized and
this will cause a runtime error with UBSan even if it isn't a real bug.
So initialize the pointer to NULL.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: d29d41e28eea ("ASoC: topology: Add support for multiple kcontrol types to a widget")
Signed-off-by: Jaska Uimonen <jaska.uimonen@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20210519100713.879958-1-jaska.uimonen@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/soc-topology.c')
| -rw-r--r-- | sound/soc/soc-topology.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index e71d98d7b116..5e65b72910e9 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -1422,7 +1422,7 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg, struct snd_soc_dapm_widget template, *widget; struct snd_soc_tplg_ctl_hdr *control_hdr; struct snd_soc_card *card = tplg->comp->card; - unsigned int *kcontrol_type; + unsigned int *kcontrol_type = NULL; struct snd_kcontrol_new *kc; int mixer_count = 0; int bytes_count = 0; |