diff options
| author | Fabio Estevam <festevam@denx.de> | 2024-03-29 01:44:12 +0300 |
|---|---|---|
| committer | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2024-04-10 16:15:30 +0300 |
| commit | 49a9bad83b4ab5dac1d7aba2615c77978bcf3984 (patch) | |
| tree | 2cb35939ca2087f106745182303e814b3b3b21b9 /scripts | |
| parent | f7aa5995910cb5e7a5419c6705f465c55973b714 (diff) | |
| download | linux-49a9bad83b4ab5dac1d7aba2615c77978bcf3984.tar.xz | |
media: ov2680: Clear the 'ret' variable on success
Since commit 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint
property verification") even when the correct 'link-frequencies'
property is passed in the devicetree, the driver fails to probe:
ov2680 1-0036: probe with driver ov2680 failed with error -22
The reason is that the variable 'ret' may contain the -EINVAL value
from a previous assignment:
ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency",
&rate);
Fix the problem by clearing 'ret' on the successful path.
Tested on imx7s-warp board with the following devicetree:
port {
ov2680_to_mipi: endpoint {
remote-endpoint = <&mipi_from_sensor>;
clock-lanes = <0>;
data-lanes = <1>;
link-frequencies = /bits/ 64 <330000000>;
};
};
Cc: stable@vger.kernel.org
Fixes: 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint property verification")
Suggested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions
