diff options
| author | Axel Forsman <axfo@kvaser.com> | 2025-05-20 14:43:31 +0300 |
|---|---|---|
| committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2025-05-20 22:35:39 +0300 |
| commit | 8256e0ca601051933e9395746817f3801fa9a6bf (patch) | |
| tree | 2687ed76eb8d4c3ccbd7b4e5eb454177d833fef5 /scripts/lib/kdoc/kdoc_output.py | |
| parent | 9176bd205ee0b2cd35073a9973c2a0936bcb579e (diff) | |
| download | linux-8256e0ca601051933e9395746817f3801fa9a6bf.tar.xz | |
can: kvaser_pciefd: Fix echo_skb race
The functions kvaser_pciefd_start_xmit() and
kvaser_pciefd_handle_ack_packet() raced to stop/wake TX queues and
get/put echo skbs, as kvaser_pciefd_can->echo_lock was only ever taken
when transmitting and KCAN_TX_NR_PACKETS_CURRENT gets decremented
prior to handling of ACKs. E.g., this caused the following error:
can_put_echo_skb: BUG! echo_skb 5 is occupied!
Instead, use the synchronization helpers in netdev_queues.h. As those
piggyback on BQL barriers, start updating in-flight packets and bytes
counts as well.
Cc: stable@vger.kernel.org
Signed-off-by: Axel Forsman <axfo@kvaser.com>
Tested-by: Jimmy Assarsson <extja@kvaser.com>
Reviewed-by: Jimmy Assarsson <extja@kvaser.com>
Link: https://patch.msgid.link/20250520114332.8961-3-axfo@kvaser.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'scripts/lib/kdoc/kdoc_output.py')
0 files changed, 0 insertions, 0 deletions