diff options
author | Peter Ujfalusi <peter.ujfalusi@linux.intel.com> | 2025-02-06 11:46:42 +0300 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2025-02-06 14:33:48 +0300 |
commit | 6fd60136d256b3b948333ebdb3835f41a95ab7ef (patch) | |
tree | f2efe82896f29b328a21afd98aca9a9724d08a48 /scripts/generate_rust_analyzer.py | |
parent | 1d44a30ae3f9195cb4eb7d81bb9ced2776232094 (diff) | |
download | linux-6fd60136d256b3b948333ebdb3835f41a95ab7ef.tar.xz |
ASoC: SOF: ipc4-topology: Harden loops for looking up ALH copiers
Other, non DAI copier widgets could have the same stream name (sname) as
the ALH copier and in that case the copier->data is NULL, no alh_data is
attached, which could lead to NULL pointer dereference.
We could check for this NULL pointer in sof_ipc4_prepare_copier_module()
and avoid the crash, but a similar loop in sof_ipc4_widget_setup_comp_dai()
will miscalculate the ALH device count, causing broken audio.
The correct fix is to harden the matching logic by making sure that the
1. widget is a DAI widget - so dai = w->private is valid
2. the dai (and thus the copier) is ALH copier
Fixes: a150345aa758 ("ASoC: SOF: ipc4-topology: add SoundWire/ALH aggregation support")
Reported-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Link: https://github.com/thesofproject/sof/pull/9652
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Liam Girdwood <liam.r.girdwood@intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://patch.msgid.link/20250206084642.14988-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'scripts/generate_rust_analyzer.py')
0 files changed, 0 insertions, 0 deletions