diff options
| author | James Smart <james.smart@broadcom.com> | 2020-11-30 21:12:26 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2020-12-01 08:19:14 +0300 |
| commit | 9d8de441db261dbb4abb989674a62d1c13fe4f93 (patch) | |
| tree | 2f317f729ba4a871a7d17bdd7b1cc77c54a2c9dd /scripts/gdb/linux/proc.py | |
| parent | 29b87e92a21605ed74888e4d2a31055d95dfafe1 (diff) | |
| download | linux-9d8de441db261dbb4abb989674a62d1c13fe4f93.tar.xz | |
scsi: lpfc: Correct null ndlp reference on routine exit
smatch correctly called out a logic error with accessing a pointer after
checking it for null:
drivers/scsi/lpfc/lpfc_els.c:2043 lpfc_cmpl_els_plogi()
error: we previously assumed 'ndlp' could be null (see line 1942)
Adjust the exit point to avoid the trace printf ndlp reference. A trace
entry was already generated when the ndlp was checked for null.
Link: https://lore.kernel.org/r/20201130181226.16675-1-james.smart@broadcom.com
Fixes: 4430f7fd09ec ("scsi: lpfc: Rework locations of ndlp reference taking")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'scripts/gdb/linux/proc.py')
0 files changed, 0 insertions, 0 deletions
