summaryrefslogtreecommitdiff
path: root/scripts/config
diff options
context:
space:
mode:
authorJeff Layton <jlayton@kernel.org>2023-03-17 20:13:08 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-03-30 13:50:53 +0300
commit0101067f376eb7b9afd00279270f25d5111a091d (patch)
treef35efc72939b0deb9131723ba9e79b5814d51ff5 /scripts/config
parent0d89254a4320eb7de0970c478172f764125c6355 (diff)
downloadlinux-0101067f376eb7b9afd00279270f25d5111a091d.tar.xz
nfsd: don't replace page in rq_pages if it's a continuation of last page
[ Upstream commit 27c934dd8832dd40fd34776f916dc201e18b319b ] The splice read calls nfsd_splice_actor to put the pages containing file data into the svc_rqst->rq_pages array. It's possible however to get a splice result that only has a partial page at the end, if (e.g.) the filesystem hands back a short read that doesn't cover the whole page. nfsd_splice_actor will plop the partial page into its rq_pages array and return. Then later, when nfsd_splice_actor is called again, the remainder of the page may end up being filled out. At this point, nfsd_splice_actor will put the page into the array _again_ corrupting the reply. If this is done enough times, rq_next_page will overrun the array and corrupt the trailing fields -- the rq_respages and rq_next_page pointers themselves. If we've already added the page to the array in the last pass, don't add it to the array a second time when dealing with a splice continuation. This was originally handled properly in nfsd_splice_actor, but commit 91e23b1c3982 ("NFSD: Clean up nfsd_splice_actor()") removed the check for it. Fixes: 91e23b1c3982 ("NFSD: Clean up nfsd_splice_actor()") Cc: Al Viro <viro@zeniv.linux.org.uk> Reported-by: Dario Lesca <d.lesca@solinos.it> Tested-by: David Critch <dcritch@redhat.com> Link: https://bugzilla.redhat.com/show_bug.cgi?id=2150630 Signed-off-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'scripts/config')
0 files changed, 0 insertions, 0 deletions