summaryrefslogtreecommitdiff
path: root/rust/helpers/helpers.c
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2025-02-18 18:39:31 +0300
committerChuck Lever <chuck.lever@oracle.com>2025-03-10 16:11:05 +0300
commitf77ce2e5708b3201244fcc61e4a22acb44fd919b (patch)
tree8d46fa6b14378a0fa77c64ae893c23f39ebd52fc /rust/helpers/helpers.c
parentdfd500d89545a1c23554e9d9d62d112c44b4c82e (diff)
downloadlinux-f77ce2e5708b3201244fcc61e4a22acb44fd919b.tar.xz
nfsd: filecache: remove race handling.
The race that this code tries to protect against is not interesting. The code is problematic as we access the "nf" after we have given our reference to the lru system. While that takes 2+ seconds to free things, it is still poor form. The only interesting race I can find would be with nfsd_file_close_inode_sync(); This is the only place that really doesn't want the file to stay on the LRU when unhashed (which is the direct consequence of the race). However for the race to happen, some other thread must own a reference to a file and be putting it while nfsd_file_close_inode_sync() is trying to close all files for an inode. If this is possible, that other thread could simply call nfsd_file_put() a little bit later and the result would be the same: not all files are closed when nfsd_file_close_inode_sync() completes. If this was really a problem, we would need to wait in close_inode_sync for the other references to be dropped. We probably don't want to do that. So it is best to simply remove this code. Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: NeilBrown <neilb@suse.de> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'rust/helpers/helpers.c')
0 files changed, 0 insertions, 0 deletions