diff options
author | Paul E. McKenney <paulmck@kernel.org> | 2025-02-06 13:15:09 +0300 |
---|---|---|
committer | Boqun Feng <boqun.feng@gmail.com> | 2025-03-05 05:44:29 +0300 |
commit | 59bed79ffdbc26af3dfba3c6453a4356c9fd6b6f (patch) | |
tree | 8c38344a9f118902b53ff476096eecddad79a611 /rust/helpers/helpers.c | |
parent | 69381f38284f107e5e55bff7e51ecd1ef7e3ced8 (diff) | |
download | linux-59bed79ffdbc26af3dfba3c6453a4356c9fd6b6f.tar.xz |
context_tracking: Make RCU watch ct_kernel_exit_state() warning
The WARN_ON_ONCE() in ct_kernel_exit_state() follows the call to
ct_state_inc(), which means that RCU is not watching this WARN_ON_ONCE().
This can (and does) result in extraneous lockdep warnings when this
WARN_ON_ONCE() triggers. These extraneous warnings are the opposite
of helpful.
Therefore, invert the WARN_ON_ONCE() condition and move it before the
call to ct_state_inc(). This does mean that the ct_state_inc() return
value can no longer be used in the WARN_ON_ONCE() condition, so discard
this return value and instead use a call to rcu_is_watching_curr_cpu().
This call is executed only in CONFIG_RCU_EQS_DEBUG=y kernels, so there
is no added overhead in production use.
[Boqun: Add the subsystem tag in the title]
Reported-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/bd911cd9-1fe9-447c-85e0-ea811a1dc896@paulmck-laptop
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Diffstat (limited to 'rust/helpers/helpers.c')
0 files changed, 0 insertions, 0 deletions