summaryrefslogtreecommitdiff
path: root/net/switchdev
diff options
context:
space:
mode:
authorPrzemek Kitszel <przemyslaw.kitszel@intel.com>2025-02-19 16:30:39 +0300
committerTony Nguyen <anthony.l.nguyen@intel.com>2025-03-05 19:45:45 +0300
commit2a3e89a14864090ee4804fcec655ffc15fabf45c (patch)
tree035ccf62cb8953f2070078a08345069482461802 /net/switchdev
parentdce97cb0a3e34204c0b99345418a714eac85953f (diff)
downloadlinux-2a3e89a14864090ee4804fcec655ffc15fabf45c.tar.xz
ice: register devlink prior to creating health reporters
ice_health_init() was introduced in the commit 2a82874a3b7b ("ice: add Tx hang devlink health reporter"). The call to it should have been put after ice_devlink_register(). It went unnoticed until next reporter by Konrad, which receives events from FW. FW is reporting all events, also from prior driver load, and thus it is not unlikely to have something at the very beginning. And that results in a splat: [ 24.455950] ? devlink_recover_notify.constprop.0+0x198/0x1b0 [ 24.455973] devlink_health_report+0x5d/0x2a0 [ 24.455976] ? __pfx_ice_health_status_lookup_compare+0x10/0x10 [ice] [ 24.456044] ice_process_health_status_event+0x1b7/0x200 [ice] Do the analogous thing for deinit patch. Fixes: 85d6164ec56d ("ice: add fw and port health reporters") Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> Reviewed-by: Konrad Knitter <konrad.knitter@intel.com> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Diffstat (limited to 'net/switchdev')
0 files changed, 0 insertions, 0 deletions