diff options
| author | Ursula Braun <ubraun@linux.vnet.ibm.com> | 2017-04-10 15:58:01 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-04-12 06:01:14 +0300 |
| commit | 46c28dbd4c23c3f7fa37f5ea48772af79c9cc40e (patch) | |
| tree | 46c18228dafa080d9a7c9ee72edd7ea4f7a6e6b3 /net/smc/smc_core.c | |
| parent | 90e9517ed9615f9fb23fbef7d279f81e6c5c08b2 (diff) | |
| download | linux-46c28dbd4c23c3f7fa37f5ea48772af79c9cc40e.tar.xz | |
net/smc: no socket state changes in tasklet context
Several state changes occur during SMC socket closing. Currently
state changes triggered locally occur in process context with
lock_sock() taken while state changes triggered by peer occur in
tasklet context with bh_lock_sock() taken. bh_lock_sock() does not
wait till a lock_sock(() task in process context is finished. This
may lead to races in socket state transitions resulting in dangling
SMC-sockets, or it may lead to duplicate SMC socket freeing.
This patch introduces a closing worker to run all state changes under
lock_sock().
Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
Reviewed-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
Reported-by: Dave Jones <davej@codemonkey.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/smc/smc_core.c')
| -rw-r--r-- | net/smc/smc_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c index 0eac633fb354..65020e93ff21 100644 --- a/net/smc/smc_core.c +++ b/net/smc/smc_core.c @@ -316,7 +316,7 @@ void smc_lgr_terminate(struct smc_link_group *lgr) smc = container_of(conn, struct smc_sock, conn); sock_hold(&smc->sk); __smc_lgr_unregister_conn(conn); - smc_close_active_abort(smc); + schedule_work(&conn->close_work); sock_put(&smc->sk); node = rb_first(&lgr->conns_all); } |