diff options
| author | Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru> | 2024-03-07 17:23:50 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-03-11 12:53:22 +0300 |
| commit | 3ed5f415133f9b7518fbe55ba9ae9a3f5e700929 (patch) | |
| tree | 6ac4aa7daee17d60aab3834ec453f7d09fa19d97 /net/kcm | |
| parent | 4bb3ba7b74fceec6f558745b25a43c6521cf5506 (diff) | |
| download | linux-3ed5f415133f9b7518fbe55ba9ae9a3f5e700929.tar.xz | |
net: kcm: fix incorrect parameter validation in the kcm_getsockopt) function
The 'len' variable can't be negative when assigned the result of
'min_t' because all 'min_t' parameters are cast to unsigned int,
and then the minimum one is chosen.
To fix the logic, check 'len' as read from 'optlen',
where the types of relevant variables are (signed) int.
Fixes: ab7ac4eb9832 ("kcm: Kernel Connection Multiplexor module")
Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/kcm')
| -rw-r--r-- | net/kcm/kcmsock.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c index dc46f17a3187..2f191e50d4fc 100644 --- a/net/kcm/kcmsock.c +++ b/net/kcm/kcmsock.c @@ -1153,10 +1153,11 @@ static int kcm_getsockopt(struct socket *sock, int level, int optname, if (get_user(len, optlen)) return -EFAULT; - len = min_t(unsigned int, len, sizeof(int)); if (len < 0) return -EINVAL; + len = min_t(unsigned int, len, sizeof(int)); + switch (optname) { case KCM_RECV_DISABLE: val = kcm->rx_disabled; |