diff options
| author | David S. Miller <davem@davemloft.net> | 2015-05-02 05:02:47 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-05-02 05:02:47 +0300 |
| commit | a134f083e79fb4c3d0a925691e732c56911b4326 (patch) | |
| tree | 0e0ebc97957d97ca517f8342b00e22d005e5631d /net/ipv4/ping.c | |
| parent | e813bb2b955d9f72c94be7d592746b49929a499b (diff) | |
| download | linux-a134f083e79fb4c3d0a925691e732c56911b4326.tar.xz | |
ipv4: Missing sk_nulls_node_init() in ping_unhash().
If we don't do that, then the poison value is left in the ->pprev
backlink.
This can cause crashes if we do a disconnect, followed by a connect().
Tested-by: Linus Torvalds <torvalds@linux-foundation.org>
Reported-by: Wen Xu <hotdog3645@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ping.c')
| -rw-r--r-- | net/ipv4/ping.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index a93f260cf24c..05ff44b758df 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -158,6 +158,7 @@ void ping_unhash(struct sock *sk) if (sk_hashed(sk)) { write_lock_bh(&ping_table.lock); hlist_nulls_del(&sk->sk_nulls_node); + sk_nulls_node_init(&sk->sk_nulls_node); sock_put(sk); isk->inet_num = 0; isk->inet_sport = 0; |