diff options
| author | Eric Dumazet <edumazet@google.com> | 2014-04-03 20:28:10 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-04-04 00:17:52 +0400 |
| commit | e33d0ba8047b049c9262fdb1fcafb93cb52ceceb (patch) | |
| tree | 2b117a4733772f5ab63ab296c79ef1290cfc40f7 /net/core | |
| parent | 240a12d58e3935945c8c0f767134f3da1ac05371 (diff) | |
| download | linux-e33d0ba8047b049c9262fdb1fcafb93cb52ceceb.tar.xz | |
net-gro: reset skb->truesize in napi_reuse_skb()
Recycling skb always had been very tough...
This time it appears GRO layer can accumulate skb->truesize
adjustments made by drivers when they attach a fragment to skb.
skb_gro_receive() can only subtract from skb->truesize the used part
of a fragment.
I spotted this problem seeing TcpExtPruneCalled and
TcpExtTCPRcvCollapsed that were unexpected with a recent kernel, where
TCP receive window should be sized properly to accept traffic coming
from a driver not overshooting skb->truesize.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/dev.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 75e88e0372cb..577701839f52 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -4043,6 +4043,7 @@ static void napi_reuse_skb(struct napi_struct *napi, struct sk_buff *skb) skb->vlan_tci = 0; skb->dev = napi->dev; skb->skb_iif = 0; + skb->truesize = SKB_TRUESIZE(skb_end_offset(skb)); napi->skb = skb; } |