diff options
| author | Eric Biggers <ebiggers@google.com> | 2024-12-02 04:08:40 +0300 |
|---|---|---|
| committer | Eric Biggers <ebiggers@google.com> | 2024-12-02 04:23:02 +0300 |
| commit | 38a9a5121c3bcf2ed857430a92e493568b247c35 (patch) | |
| tree | 0c3b00d05b9fd06890f530ac7aa9c5c517ed9773 /lib/Kconfig | |
| parent | cc354fa7f0160a96896a3b8d7f298a036e3b8602 (diff) | |
| download | linux-38a9a5121c3bcf2ed857430a92e493568b247c35.tar.xz | |
lib/crc32: make crc32c() go directly to lib
Now that the lower level __crc32c_le() library function is optimized for
each architecture, make crc32c() just call that instead of taking an
inefficient and error-prone detour through the shash API.
Note: a future cleanup should make crc32c_le() be the actual library
function instead of __crc32c_le(). That will require updating callers
of __crc32c_le() to use crc32c_le() instead, and updating callers of
crc32c_le() that expect a 'const void *' arg to expect 'const u8 *'
instead. Similarly, a future cleanup should remove LIBCRC32C by making
everyone who is selecting it just select CRC32 directly instead.
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20241202010844.144356-16-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Diffstat (limited to 'lib/Kconfig')
| -rw-r--r-- | lib/Kconfig | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/lib/Kconfig b/lib/Kconfig index 8858030bebae..d0c2dc0dac32 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -310,14 +310,10 @@ config CRC7 config LIBCRC32C tristate "CRC32c (Castagnoli, et al) Cyclic Redundancy-Check" - select CRYPTO - select CRYPTO_CRC32C + select CRC32 help - This option is provided for the case where no in-kernel-tree - modules require CRC32c functions, but a module built outside the - kernel tree does. Such modules that use library CRC32c functions - require M here. See Castagnoli93. - Module will be libcrc32c. + This option just selects CRC32 and is provided for compatibility + purposes until the users are updated to select CRC32 directly. config CRC8 tristate "CRC8 function" |