diff options
| author | Mark Brown <broonie@kernel.org> | 2025-12-15 04:10:13 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2025-12-15 04:10:13 +0300 |
| commit | c5224b8a1ba52d70b3fc2548109bd04bbbc0c8a6 (patch) | |
| tree | 20319716092b909203bde66290f0705d87c7fdaa /include | |
| parent | 81acbdc51bbbec822a1525481f2f70677c47aee0 (diff) | |
| parent | 0bb160c92ad400c692984763996b758458adea17 (diff) | |
| download | linux-c5224b8a1ba52d70b3fc2548109bd04bbbc0c8a6.tar.xz | |
ASoC: qcom: Fix confusing cleanup.h
Merge series from Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>:
Please, please stop ending cleanup.h patches for very simple code like:
foo = kzalloc();
kfree(foo);
return;
... *if you do not intend to read cleanup.h*. These changes are making
simple code not necessarily simpler. But worse, if you do not read
cleanup.h then you introduce actually undesired, error-prone and wrong
style of having constructors with redundant values (= NULL).
This is actually worse code.
If you do not agree in declaration-in-place-of-use (fair!), then do not
use cleanup.h. If you want to use cleanup.h, then please read cleanup.h
before.
This is second mixup I see recently around Qualcomm files.
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions
