summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authormatteo.cotifava <cotifavamatteo@gmail.com>2026-03-10 00:54:12 +0300
committerMark Brown <broonie@kernel.org>2026-03-10 01:22:41 +0300
commit95bc5c225513fc3c4ce169563fb5e3929fbb938b (patch)
treef98500286cce0c0bcbbc47ed32e9d33527229899 /include
parent3c99c9f0ed60582c1c9852b685d78d5d3a50de63 (diff)
downloadlinux-95bc5c225513fc3c4ce169563fb5e3929fbb938b.tar.xz
ASoC: soc-core: flush delayed work before removing DAIs and widgets
When a sound card is unbound while a PCM stream is open, a use-after-free can occur in snd_soc_dapm_stream_event(), called from the close_delayed_work workqueue handler. During unbind, snd_soc_unbind_card() flushes delayed work and then calls soc_cleanup_card_resources(). Inside cleanup, snd_card_disconnect_sync() releases all PCM file descriptors, and the resulting PCM close path can call snd_soc_dapm_stream_stop() which schedules new delayed work with a pmdown_time timer delay. Since this happens after the flush in snd_soc_unbind_card(), the new work is not caught. soc_remove_link_components() then frees DAPM widgets before this work fires, leading to the use-after-free. The existing flush in soc_free_pcm_runtime() also cannot help as it runs after soc_remove_link_components() has already freed the widgets. Add a flush in soc_cleanup_card_resources() after snd_card_disconnect_sync() (after which no new PCM closes can schedule further delayed work) and before soc_remove_link_dais() and soc_remove_link_components() (which tear down the structures the delayed work accesses). Fixes: e894efef9ac7 ("ASoC: core: add support to card rebind") Signed-off-by: Matteo Cotifava <cotifavamatteo@gmail.com> Link: https://patch.msgid.link/20260309215412.545628-3-cotifavamatteo@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions