diff options
| author | Paolo Abeni <pabeni@redhat.com> | 2024-10-24 17:04:27 +0300 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2024-10-24 17:04:28 +0300 |
| commit | 8b448f0dbcae0c18c3fb97caf8aeff5fec19a9a2 (patch) | |
| tree | b4400b49c6e28c4f2de27509b4868f1064cb52c3 /include | |
| parent | 1bf70e6c3a5346966c25e0a1ff492945b25d3f80 (diff) | |
| parent | 17a1ac0018ae1cee0b2c2235ce54e91ecbbed7be (diff) | |
| download | linux-8b448f0dbcae0c18c3fb97caf8aeff5fec19a9a2.tar.xz | |
Merge branch 'phonet-convert-all-doit-and-dumpit-to-rcu'
Kuniyuki Iwashima says:
====================
phonet: Convert all doit() and dumpit() to RCU.
addr_doit() and route_doit() access only phonet_device_list(dev_net(dev))
and phonet_pernet(dev_net(dev))->routes, respectively.
Each per-netns struct has its dedicated mutex, and RTNL also protects
the structs. __dev_change_net_namespace() has synchronize_net(), so
we have two options to convert addr_doit() and route_doit().
1. Use per-netns RTNL
2. Use RCU and convert each struct mutex to spinlock_t
As RCU is preferable, this series converts all PF_PHONET's doit()
and dumpit() to RCU.
4 doit()s and 1 dumpit() are now converted to RCU, 70 doit()s and
28 dumpit()s are still under RTNL.
====================
Link: https://patch.msgid.link/20241017183140.43028-1-kuniyu@amazon.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/phonet/pn_dev.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/net/phonet/pn_dev.h b/include/net/phonet/pn_dev.h index e9dc8dca5817..37a3e83531c6 100644 --- a/include/net/phonet/pn_dev.h +++ b/include/net/phonet/pn_dev.h @@ -11,13 +11,13 @@ #define PN_DEV_H #include <linux/list.h> -#include <linux/mutex.h> +#include <linux/spinlock.h> struct net; struct phonet_device_list { struct list_head list; - struct mutex lock; + spinlock_t lock; }; struct phonet_device_list *phonet_device_list(struct net *net); @@ -38,11 +38,11 @@ int phonet_address_add(struct net_device *dev, u8 addr); int phonet_address_del(struct net_device *dev, u8 addr); u8 phonet_address_get(struct net_device *dev, u8 addr); int phonet_address_lookup(struct net *net, u8 addr); -void phonet_address_notify(int event, struct net_device *dev, u8 addr); +void phonet_address_notify(struct net *net, int event, u32 ifindex, u8 addr); int phonet_route_add(struct net_device *dev, u8 daddr); int phonet_route_del(struct net_device *dev, u8 daddr); -void rtm_phonet_notify(int event, struct net_device *dev, u8 dst); +void rtm_phonet_notify(struct net *net, int event, u32 ifindex, u8 dst); struct net_device *phonet_route_get_rcu(struct net *net, u8 daddr); struct net_device *phonet_route_output(struct net *net, u8 daddr); |