summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2026-05-26 17:55:29 +0300
committerJakub Kicinski <kuba@kernel.org>2026-05-28 03:27:26 +0300
commit331d846a717243cec2d0708d30926efe97bb6294 (patch)
tree576d7befbd275ba831dbdd0fdc54249339a6849a /include
parent507541c2a8eeb76c02bd2511958f73a8cfa3e1bc (diff)
downloadlinux-331d846a717243cec2d0708d30926efe97bb6294.tar.xz
ipv6: frags: cleanup __IP6_INC_STATS() confusion
After commits e1ae5c2ea478 ("vrf: Increment Icmp6InMsgs on the original netdev") and bdb7cc643fc9 ("ipv6: Count interface receive statistics on the ingress netdev") net/ipv6/reassembly.c uses three different ways to reach idev in various __IP6_INC_STATS() calls. - ip6_dst_idev(skb_dst(skb)) - __in6_dev_get_safely(skb->dev) - __in6_dev_stats_get(skb->dev) Lets centralize this from ipv6_frag_rcv() and use __in6_dev_stats_get(). Note that ipv6_frag_rcv() tests if skb->dev could be NULL already, so I chose to also guard against NULL, but we probably can remove the tests in a followup patch, because I do not think skb->dev could be NULL. iif = skb->dev ? skb->dev->ifindex : 0; idev can be NULL, __IP6_INC_STATS() deals with this possibility. Small code size reduction as a bonus. $ scripts/bloat-o-meter -t vmlinux.old vmlinux.new add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-145 (-145) Function old new delta ipv6_frag_rcv 2399 2362 -37 ip6_frag_reasm 705 597 -108 Total: Before=31455552, After=31455407, chg -0.00% Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Ido Schimmel <idosch@nvidia.com> Link: https://patch.msgid.link/20260526145529.3587126-3-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions