diff options
| author | Christian König <christian.koenig@amd.com> | 2024-12-10 12:08:42 +0300 |
|---|---|---|
| committer | Christian König <christian.koenig@amd.com> | 2025-03-06 17:20:43 +0300 |
| commit | 2b2d7ca7ce25fbec8389e7d85e57742caa47c97d (patch) | |
| tree | 2644dd2fdf06d15185c3bfdd52264cfd7fb39e53 /include | |
| parent | 4423e607ff50157aaf088854b145936cbab4d560 (diff) | |
| download | linux-2b2d7ca7ce25fbec8389e7d85e57742caa47c97d.tar.xz | |
dma-buf: fix incorrect dma-fence documentation v2
There isn't much worse than documentation giving an incorrect advise.
Grabbing a spinlock while interrupts are disabled usually means that you
must also disable interrupts for all other uses of this spinlock.
Otherwise really hard to debug issues can occur. So fix that invalid
documentation.
v2: use Dmitry's suggestion on the documentation
Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch> (v1)
Link: https://patchwork.freedesktop.org/patch/msgid/20250211163109.12200-2-christian.koenig@amd.com
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/dma-fence.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h index e7ad819962e3..52587d390aca 100644 --- a/include/linux/dma-fence.h +++ b/include/linux/dma-fence.h @@ -169,8 +169,8 @@ struct dma_fence_ops { * implementation know that there is another driver waiting on the * signal (ie. hw->sw case). * - * This function can be called from atomic context, but not - * from irq context, so normal spinlocks can be used. + * This is called with irq's disabled, so only spinlocks which disable + * IRQ's can be used in the code outside of this callback. * * A return value of false indicates the fence already passed, * or some failure occurred that made it impossible to enable |