summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorTycho Andersen (AMD) <tycho@kernel.org>2026-05-04 19:51:47 +0300
committerHerbert Xu <herbert@gondor.apana.org.au>2026-05-15 13:08:37 +0300
commit08f0e65e784c4b20e6e620dd4f68d8636073a3d2 (patch)
treef284c8202525b40de6fb6c5f28313541957a2681 /include
parentf91e9dbb5845d1e5abf1028e6df57dcf61583e1b (diff)
downloadlinux-08f0e65e784c4b20e6e620dd4f68d8636073a3d2.tar.xz
crypto: ccp - Do not initialize SNP for ioctl(SNP_CONFIG)
Sashiko notes: > if SEV initialization fails and KVM is actively running normal VMs, could a > userspace process trigger this code path via /dev/sev ioctls (e.g., > SEV_PDH_GEN) and zero out MSR_VM_HSAVE_PA globally? Would the next VMRUN > execution for an active VM trigger a general protection fault and crash the > host? Refuse to re-try initialization if SNP is not already initialized for SNP_CONFIG. This is technically an ABI break: before if SNP initialization failed it could be transparently retriggered by this ioctl, and if no VMs were running, everything worked fine. Hopefully this is enough of a corner case that nobody will notice, but someone does, there are a few options: * do something like symbol_get() for kvm and refuse to initialize if KVM is loaded * check each cpu's HSAVE_PA for non-zero data before re-initializing * once initialization has failed, continue to refuse to initialize until the ccp module is unloaded Fixes: ceac7fb89e8d ("crypto: ccp - Ensure implicit SEV/SNP init and shutdown in ioctls") Reported-by: Sashiko Assisted-by: Gemini:gemini-3.1-pro-preview Link: https://sashiko.dev/#/patchset/20260324161301.1353976-1-tycho%40kernel.org CC: <stable@vger.kernel.org> Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions