diff options
| author | Wang Hai <wanghai38@huawei.com> | 2020-06-09 17:18:16 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-06-09 23:26:23 +0300 |
| commit | c96b6acc8f89a4a7f6258dfe1d077654c11415be (patch) | |
| tree | 117d45f01a2bbbebf6b8fd2158686d9133a2afa6 /include/net | |
| parent | 976ee3b21119dcf5c6d96233d688a1453f29fa83 (diff) | |
| download | linux-c96b6acc8f89a4a7f6258dfe1d077654c11415be.tar.xz | |
dccp: Fix possible memleak in dccp_init and dccp_fini
There are some memory leaks in dccp_init() and dccp_fini().
In dccp_fini() and the error handling path in dccp_init(), free lhash2
is missing. Add inet_hashinfo2_free_mod() to do it.
If inet_hashinfo2_init_mod() failed in dccp_init(),
percpu_counter_destroy() should be called to destroy dccp_orphan_count.
It need to goto out_free_percpu when inet_hashinfo2_init_mod() failed.
Fixes: c92c81df93df ("net: dccp: fix kernel crash on module load")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net')
| -rw-r--r-- | include/net/inet_hashtables.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/include/net/inet_hashtables.h b/include/net/inet_hashtables.h index ad64ba6a057f..92560974ea67 100644 --- a/include/net/inet_hashtables.h +++ b/include/net/inet_hashtables.h @@ -185,6 +185,12 @@ static inline spinlock_t *inet_ehash_lockp( int inet_ehash_locks_alloc(struct inet_hashinfo *hashinfo); +static inline void inet_hashinfo2_free_mod(struct inet_hashinfo *h) +{ + kfree(h->lhash2); + h->lhash2 = NULL; +} + static inline void inet_ehash_locks_free(struct inet_hashinfo *hashinfo) { kvfree(hashinfo->ehash_locks); |