diff options
| author | Jakob Hauser <jahau@rocketmail.com> | 2023-05-15 23:57:11 +0300 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2023-06-08 20:16:28 +0300 |
| commit | c4747d7ce3948766cdae2404b4a796ba4cda9d7d (patch) | |
| tree | efd4698ed3966ed84a68b5c549ded4a46a05b230 /include/linux/mfd | |
| parent | 43db1344e0f8c1eb687a1d6cd5b0de3009ab66cb (diff) | |
| download | linux-c4747d7ce3948766cdae2404b4a796ba4cda9d7d.tar.xz | |
mfd: rt5033: Fix chip revision readout
After reading the data from the DEVICE_ID register, mask 0x0f needs to be
applied to extract the revision of the chip [1].
The other part of the DEVICE_ID register, mask 0xf0, is a vendor identification
code. That's how it is set up at similar products of Richtek, e.g. RT9455 [2]
page 21 top.
[1] https://github.com/msm8916-mainline/linux-downstream/blob/GT-I9195I/drivers/mfd/rt5033_core.c#L484
[2] https://www.richtek.com/assets/product_file/RT9455/DS9455-00.pdf
Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/9a98521ffdf76851d5d344afa6ce65f692ecc024.1684182964.git.jahau@rocketmail.com
Diffstat (limited to 'include/linux/mfd')
| -rw-r--r-- | include/linux/mfd/rt5033-private.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/include/linux/mfd/rt5033-private.h b/include/linux/mfd/rt5033-private.h index 6bb432f6a96c..b035a67cec73 100644 --- a/include/linux/mfd/rt5033-private.h +++ b/include/linux/mfd/rt5033-private.h @@ -71,6 +71,10 @@ enum rt5033_reg { /* RT5033 CHGCTRL2 register */ #define RT5033_CHGCTRL2_CV_MASK 0xfc +/* RT5033 DEVICE_ID register */ +#define RT5033_VENDOR_ID_MASK 0xf0 +#define RT5033_CHIP_REV_MASK 0x0f + /* RT5033 CHGCTRL3 register */ #define RT5033_CHGCTRL3_CFO_EN_MASK 0x40 #define RT5033_CHGCTRL3_TIMER_MASK 0x38 |