diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2024-11-06 19:14:41 +0300 |
---|---|---|
committer | Masahiro Yamada <masahiroy@kernel.org> | 2024-11-27 03:38:27 +0300 |
commit | dbefa1f31a91670c9e7dac9b559625336206466f (patch) | |
tree | ed1f7bb74bceef60e8c660d08229881fcd23a9bb /include/linux/dlm.h | |
parent | bb43a59944f45e89aa158740b8a16ba8f0b0fa2b (diff) | |
download | linux-dbefa1f31a91670c9e7dac9b559625336206466f.tar.xz |
Rename .data.once to .data..once to fix resetting WARN*_ONCE
Commit b1fca27d384e ("kernel debug: support resetting WARN*_ONCE")
added support for clearing the state of once warnings. However,
it is not functional when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION or
CONFIG_LTO_CLANG is enabled, because .data.once matches the
.data.[0-9a-zA-Z_]* pattern in the DATA_MAIN macro.
Commit cb87481ee89d ("kbuild: linker script do not match C names unless
LD_DEAD_CODE_DATA_ELIMINATION is configured") was introduced to suppress
the issue for the default CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=n case,
providing a minimal fix for stable backporting. We were aware this did
not address the issue for CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=y. The
plan was to apply correct fixes and then revert cb87481ee89d. [1]
Seven years have passed since then, yet the #ifdef workaround remains in
place. Meanwhile, commit b1fca27d384e introduced the .data.once section,
and commit dc5723b02e52 ("kbuild: add support for Clang LTO") extended
the #ifdef.
Using a ".." separator in the section name fixes the issue for
CONFIG_LD_DEAD_CODE_DATA_ELIMINATION and CONFIG_LTO_CLANG.
[1]: https://lore.kernel.org/linux-kbuild/CAK7LNASck6BfdLnESxXUeECYL26yUDm0cwRZuM4gmaWUkxjL5g@mail.gmail.com/
Fixes: b1fca27d384e ("kernel debug: support resetting WARN*_ONCE")
Fixes: dc5723b02e52 ("kbuild: add support for Clang LTO")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'include/linux/dlm.h')
0 files changed, 0 insertions, 0 deletions