summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorZev Weiss <zev@bewilderbeest.net>2022-08-10 08:26:46 +0300
committerGuenter Roeck <linux@roeck-us.net>2022-08-10 16:37:01 +0300
commitf4e6960f4f16b1ca5da16cec7612ecc86402ac05 (patch)
tree97d59bedcf95242153ac19413e82955213bfe979 /fs
parent7aeef1548ac026c8bcb9ec223b672f81da340011 (diff)
downloadlinux-f4e6960f4f16b1ca5da16cec7612ecc86402ac05.tar.xz
hwmon: (nct6775) Fix platform driver suspend regression
Commit c3963bc0a0cf ("hwmon: (nct6775) Split core and platform driver") introduced a slight change in nct6775_suspend() in order to avoid an otherwise-needless symbol export for nct6775_update_device(), replacing a call to that function with a simple dev_get_drvdata() instead. As it turns out, there is no guarantee that nct6775_update_device() is ever called prior to suspend. If this happens, the resume function ends up writing bad data into the various chip registers, which results in a crash shortly after resume. To fix the problem, just add the symbol export and return to using nct6775_update_device() as was employed previously. Reported-by: Zoltán Kővágó <dirty.ice.hu@gmail.com> Tested-by: Zoltán Kővágó <dirty.ice.hu@gmail.com> Fixes: c3963bc0a0cf ("hwmon: (nct6775) Split core and platform driver") Cc: stable@kernel.org Signed-off-by: Zev Weiss <zev@bewilderbeest.net> Link: https://lore.kernel.org/r/20220810052646.13825-1-zev@bewilderbeest.net [groeck: Updated description] Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions