diff options
| author | Miquel Raynal <miquel.raynal@bootlin.com> | 2022-01-25 15:14:23 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-02-23 13:56:39 +0300 |
| commit | d2a1eaf51b7d4412319adb6acef114ba472d1692 (patch) | |
| tree | 2a64d8cae3f4d011c93a2df39741e2fc600d6a69 /fs/jbd2/commit.c | |
| parent | 6afc76b44eb52f11cbbbace33daa5b27ef9cd52f (diff) | |
| download | linux-d2a1eaf51b7d4412319adb6acef114ba472d1692.tar.xz | |
net: ieee802154: at86rf230: Stop leaking skb's
[ Upstream commit e5ce576d45bf72fd0e3dc37eff897bfcc488f6a9 ]
Upon error the ieee802154_xmit_complete() helper is not called. Only
ieee802154_wake_queue() is called manually. In the Tx case we then leak
the skb structure.
Free the skb structure upon error before returning when appropriate.
As the 'is_tx = 0' cannot be moved in the complete handler because of a
possible race between the delay in switching to STATE_RX_AACK_ON and a
new interrupt, we introduce an intermediate 'was_tx' boolean just for
this purpose.
There is no Fixes tag applying here, many changes have been made on this
area and the issue kind of always existed.
Suggested-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Alexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20220125121426.848337-4-miquel.raynal@bootlin.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs/jbd2/commit.c')
0 files changed, 0 insertions, 0 deletions