diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2022-03-21 07:15:53 +0300 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-23 00:09:30 +0300 |
| commit | ce6201c456571d919e722eec3c17f868f0575b05 (patch) | |
| tree | fa7281175f4d7d823da49cff85596b2d7b53e92f /fs/bcachefs/super.c | |
| parent | 95752a02cb5d38bc97d76625de2607510ac94e69 (diff) | |
| download | linux-ce6201c456571d919e722eec3c17f868f0575b05.tar.xz | |
bcachefs: Use a genradix for reading journal entries
Previously, the journal read path used a linked list for storing the
journal entries we read from disk. But there's been a bug that's been
causing journal_flush_delay to incorrectly be set to 0, leading to far
more journal entries than is normal being written out, which then means
filesystems are no longer able to start due to the O(n^2) behaviour of
inserting into/searching that linked list.
Fix this by switching to a radix tree.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Diffstat (limited to 'fs/bcachefs/super.c')
| -rw-r--r-- | fs/bcachefs/super.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c index 2c3d0546f2b6..689c82f6cb5d 100644 --- a/fs/bcachefs/super.c +++ b/fs/bcachefs/super.c @@ -457,7 +457,7 @@ static void __bch2_fs_free(struct bch_fs *c) bch2_io_clock_exit(&c->io_clock[READ]); bch2_fs_compress_exit(c); bch2_journal_keys_free(&c->journal_keys); - bch2_journal_entries_free(&c->journal_entries); + bch2_journal_entries_free(c); percpu_free_rwsem(&c->mark_lock); free_percpu(c->online_reserved); @@ -676,7 +676,6 @@ static struct bch_fs *bch2_fs_alloc(struct bch_sb *sb, struct bch_opts opts) INIT_WORK(&c->journal_seq_blacklist_gc_work, bch2_blacklist_entries_gc); - INIT_LIST_HEAD(&c->journal_entries); INIT_LIST_HEAD(&c->journal_iters); INIT_LIST_HEAD(&c->fsck_errors); |