diff options
| author | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-04-28 10:38:56 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-05-10 12:36:33 +0300 |
| commit | 747bad54a677d8633ec14b39dfbeb859c821d7f2 (patch) | |
| tree | e1ace1c22fa2cfcbf052baaad47f5ac48980671f /drivers | |
| parent | 4cba5473c5ce0f1389d316c5dc6f83a0259df5eb (diff) | |
| download | linux-747bad54a677d8633ec14b39dfbeb859c821d7f2.tar.xz | |
media: s5p_cec: decrement usage count if disabled
There's a bug at s5p_cec_adap_enable(): if called to
disable the device, it should call pm_runtime_put()
instead of pm_runtime_disable(), as the goal here is to
decrement the usage_count and not to disable PM runtime.
Reported-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Fixes: 1bcbf6f4b6b0 ("[media] cec: s5p-cec: Add s5p-cec driver")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/media/cec/platform/s5p/s5p_cec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/cec/platform/s5p/s5p_cec.c b/drivers/media/cec/platform/s5p/s5p_cec.c index 2a3e7ffefe0a..3c7c4c3c798c 100644 --- a/drivers/media/cec/platform/s5p/s5p_cec.c +++ b/drivers/media/cec/platform/s5p/s5p_cec.c @@ -51,7 +51,7 @@ static int s5p_cec_adap_enable(struct cec_adapter *adap, bool enable) } else { s5p_cec_mask_tx_interrupts(cec); s5p_cec_mask_rx_interrupts(cec); - pm_runtime_disable(cec->dev); + pm_runtime_put(cec->dev); } return 0; |