diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-01-23 00:28:08 +0300 |
|---|---|---|
| committer | Felipe Balbi <felipe.balbi@linux.intel.com> | 2019-01-28 16:27:21 +0300 |
| commit | 07c69f1148da7de3978686d3af9263325d9d60bd (patch) | |
| tree | f53fd268280d847c697af3c98d0f7e1bc9994f5c /drivers/usb/gadget/udc/net2272.c | |
| parent | 1e19cdc8060227b0802bda6bc0bd22b23679ba32 (diff) | |
| download | linux-07c69f1148da7de3978686d3af9263325d9d60bd.tar.xz | |
usb: gadget: udc: net2272: Fix bitwise and boolean operations
(!x & y) strikes again.
Fix bitwise and boolean operations by enclosing the expression:
intcsr & (1 << NET2272_PCI_IRQ)
in parentheses, before applying the boolean operator '!'.
Notice that this code has been there since 2011. So, it would
be helpful if someone can double-check this.
This issue was detected with the help of Coccinelle.
Fixes: ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device controller")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers/usb/gadget/udc/net2272.c')
| -rw-r--r-- | drivers/usb/gadget/udc/net2272.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c index 660878a19505..b77f3126580e 100644 --- a/drivers/usb/gadget/udc/net2272.c +++ b/drivers/usb/gadget/udc/net2272.c @@ -2083,7 +2083,7 @@ static irqreturn_t net2272_irq(int irq, void *_dev) #if defined(PLX_PCI_RDK2) /* see if PCI int for us by checking irqstat */ intcsr = readl(dev->rdk2.fpga_base_addr + RDK2_IRQSTAT); - if (!intcsr & (1 << NET2272_PCI_IRQ)) { + if (!(intcsr & (1 << NET2272_PCI_IRQ))) { spin_unlock(&dev->lock); return IRQ_NONE; } |