diff options
| author | Zhu Wang <wangzhu9@huawei.com> | 2023-08-19 11:39:41 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2023-08-25 05:30:32 +0300 |
| commit | 1bd3a76880b2bce017987cf53780b372cf59528e (patch) | |
| tree | baa0b623189b409001a934d6d14335657b0b2ce8 /drivers/scsi/aacraid/commctrl.c | |
| parent | 60c5fd2e8f3c42a5abc565ba9876ead1da5ad2b7 (diff) | |
| download | linux-1bd3a76880b2bce017987cf53780b372cf59528e.tar.xz | |
scsi: snic: Fix double free in snic_tgt_create()
Commit 41320b18a0e0 ("scsi: snic: Fix possible memory leak if device_add()
fails") fixed the memory leak caused by dev_set_name() when device_add()
failed. However, it did not consider that 'tgt' has already been released
when put_device(&tgt->dev) is called. Remove kfree(tgt) in the error path
to avoid double free of 'tgt' and move put_device(&tgt->dev) after the
removed kfree(tgt) to avoid a use-after-free.
Fixes: 41320b18a0e0 ("scsi: snic: Fix possible memory leak if device_add() fails")
Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Link: https://lore.kernel.org/r/20230819083941.164365-1-wangzhu9@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/aacraid/commctrl.c')
0 files changed, 0 insertions, 0 deletions