diff options
author | Marc Zyngier <marc.zyngier@arm.com> | 2016-01-26 16:52:26 +0300 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2016-01-26 18:00:15 +0300 |
commit | 14a0db3cdd114da757197193f66786e63649c91e (patch) | |
tree | 2baf3f35a85954d6effc0a43aae3ee3294a128dc /drivers/rtc/rtc-s35390a.c | |
parent | 530cbe100ef7587aa5b5ac3a4b670cda4d50e598 (diff) | |
download | linux-14a0db3cdd114da757197193f66786e63649c91e.tar.xz |
of: MSI: Simplify irqdomain lookup
So far, when trying to associate a device with its MSI domain,
we first lookup the domain using a MSI token, and if this
doesn't return anything useful, we pick up any domain matching
the same node.
This logic is broken for two reasons:
1) Only the generic MSI code (PCI or platform) sets this token
to PCI/MSI or platform MSI. So we're guaranteed that if there
is something to be found, we will find it with the first call.
2) If we have a convoluted situation where:
- a single node implements both wired and MSI interrupts
- MSI support for that HW hasn't been compiled in
we'll end up using the wired domain for MSIs anyway, and things
break badly.
So let's just remove __of_get_msi_domain, and replace it by a direct
call to irq_find_matching_host, because that's what we really want.
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Acked-by: Rob Herring <robh+dt@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Link: http://lkml.kernel.org/r/1453816347-32720-3-git-send-email-marc.zyngier@arm.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'drivers/rtc/rtc-s35390a.c')
0 files changed, 0 insertions, 0 deletions