diff options
| author | Azael Avalos <coproscefalo@gmail.com> | 2016-09-07 18:28:13 +0300 |
|---|---|---|
| committer | Darren Hart <dvhart@linux.intel.com> | 2016-09-24 02:21:05 +0300 |
| commit | 55455449982564da833d51b28bdd39a06ad28740 (patch) | |
| tree | 42a2ee30bb0f989fba3f5cf1d1dc012d2ba6076b /drivers/platform | |
| parent | 6f7e357bf181b5a9da9daffcd40a64ee516a29e4 (diff) | |
| download | linux-55455449982564da833d51b28bdd39a06ad28740.tar.xz | |
platform/x86: toshiba_haps: Split ACPI and HDD protection error handling
Currently the code checking for the ACPI status is mixed along with
the actual HDD protection status check.
This patch splits those two checks as they are not related, printing
an error string in case the ACPI call failed, and then check for
actual HDD protection status.
Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Diffstat (limited to 'drivers/platform')
| -rw-r--r-- | drivers/platform/x86/toshiba_haps.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/drivers/platform/x86/toshiba_haps.c b/drivers/platform/x86/toshiba_haps.c index 7f2afc6b5eb9..094f3a898d91 100644 --- a/drivers/platform/x86/toshiba_haps.c +++ b/drivers/platform/x86/toshiba_haps.c @@ -168,9 +168,13 @@ static int toshiba_haps_available(acpi_handle handle) * A non existent device as well as having (only) * Solid State Drives can cause the call to fail. */ - status = acpi_evaluate_integer(handle, "_STA", NULL, - &hdd_present); - if (ACPI_FAILURE(status) || !hdd_present) { + status = acpi_evaluate_integer(handle, "_STA", NULL, &hdd_present); + if (ACPI_FAILURE(status)) { + pr_err("ACPI call to query HDD protection failed\n"); + return 0; + } + + if (!hdd_present) { pr_info("HDD protection not available or using SSD\n"); return 0; } |