diff options
author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2018-11-29 20:44:45 +0300 |
---|---|---|
committer | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2018-12-03 22:40:03 +0300 |
commit | 6a31061833a52a79c99221b6251db08cf377470e (patch) | |
tree | fe3ca3faeb7e26724f644a44921547c1fd7de8dd /drivers/platform/x86/touchscreen_dmi.c | |
parent | 8a7d7141528ad67e465bc6afacc6a3144d1fe320 (diff) | |
download | linux-6a31061833a52a79c99221b6251db08cf377470e.tar.xz |
platform/x86: Fix config space access for intel_atomisp2_pm
We lose even config space access when we power gate the ISP
via the PUNIT. That makes lspci & co. produce gibberish.
To fix that let's try to implement actual runtime pm hooks
and inform the pci core that the device always goes to
D3cold. That will cause the pci core to resume the device
before attempting config space access.
This introduces another annoyance though. We get the
following error every time we try to resume the device:
intel_atomisp2_pm 0000:00:03.0: Refused to change power state, currently in D3
The reason being that the pci core tries to put the device
back into D0 via the standard PCI PM mechanism before
calling the driver resume hook. To fix this properly
we'd need to infiltrate the platform pm hooks (could
turn ugly real fast), or use pm domains (which don't
seem to exist on x86), or some extra early resume
hook for the driver (which doesn't exist either).
So maybe we just choose to live with the error?
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Darren Hart <dvhart@infradead.org>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/x86/touchscreen_dmi.c')
0 files changed, 0 insertions, 0 deletions