diff options
| author | Qianfeng Rong <rongqianfeng@vivo.com> | 2025-08-26 16:50:19 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-08-28 04:17:15 +0300 |
| commit | f0c88a0d83b26bcfbb3463d3a283bc08007a5ae0 (patch) | |
| tree | cd67d72012a39a0ee713141c8fdd0e8e91f6a3bc /drivers/net/wwan/iosm/iosm_ipc_pcie.c | |
| parent | 6aff3699906bd1017fd9017bed133681b0eb8a42 (diff) | |
| download | linux-f0c88a0d83b26bcfbb3463d3a283bc08007a5ae0.tar.xz | |
net: wwan: iosm: use int type to store negative error codes
The 'ret' variable in ipc_pcie_resources_request() either stores '-EBUSY'
directly or holds returns from pci_request_regions() and ipc_acquire_irq().
Storing negative error codes in u32 causes no runtime issues but is
stylistically inconsistent and very ugly. Change 'ret' from u32 to int
type - this has no runtime impact.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Link: https://patch.msgid.link/20250826135021.510767-1-rongqianfeng@vivo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/wwan/iosm/iosm_ipc_pcie.c')
| -rw-r--r-- | drivers/net/wwan/iosm/iosm_ipc_pcie.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wwan/iosm/iosm_ipc_pcie.c b/drivers/net/wwan/iosm/iosm_ipc_pcie.c index a066977af0be..08ff0d6ccfab 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_pcie.c +++ b/drivers/net/wwan/iosm/iosm_ipc_pcie.c @@ -69,7 +69,7 @@ static int ipc_pcie_resources_request(struct iosm_pcie *ipc_pcie) { struct pci_dev *pci = ipc_pcie->pci; u32 cap = 0; - u32 ret; + int ret; /* Reserved PCI I/O and memory resources. * Mark all PCI regions associated with PCI device pci as |