summaryrefslogtreecommitdiff
path: root/drivers/net/wireless
diff options
context:
space:
mode:
authorYannick Vignon <yannick.vignon@nxp.com>2021-01-13 16:15:56 +0300
committerJakub Kicinski <kuba@kernel.org>2021-01-14 21:49:42 +0300
commitb76889ff51bfee318bea15891420e5aefd2833a0 (patch)
tree87b387a3fe09f874a3f2859ac3d2f1494596bd35 /drivers/net/wireless
parent25764779298f23a659f3daf39f9e2b5975a7a89d (diff)
downloadlinux-b76889ff51bfee318bea15891420e5aefd2833a0.tar.xz
net: stmmac: fix taprio schedule configuration
When configuring a 802.1Qbv schedule through the tc taprio qdisc on an NXP i.MX8MPlus device, the effective cycle time differed from the requested one by N*96ns, with N number of entries in the Qbv Gate Control List. This is because the driver was adding a 96ns margin to each interval of the GCL, apparently to account for the IPG. The problem was observed on NXP i.MX8MPlus devices but likely affected all devices relying on the same configuration callback (dwmac 4.00, 4.10, 5.10 variants). Fix the issue by removing the margins, and simply setup the MAC with the provided cycle time value. This is the behavior expected by the user-space API, as altering the Qbv schedule timings would break standards conformance. This is also the behavior of several other Ethernet MAC implementations supporting taprio, including the dwxgmac variant of stmmac. Fixes: 504723af0d85 ("net: stmmac: Add basic EST support for GMAC5+") Signed-off-by: Yannick Vignon <yannick.vignon@nxp.com> Link: https://lore.kernel.org/r/20210113131557.24651-1-yannick.vignon@oss.nxp.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/wireless')
0 files changed, 0 insertions, 0 deletions