diff options
| author | Zheng Wang <zyytlz.wz@163.com> | 2023-03-16 19:15:26 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-03-19 13:42:02 +0300 |
| commit | e8d20c3ded59a092532513c9bd030d1ea66f5f44 (patch) | |
| tree | a94160e25bb15a95b9554c3cb4a1edbe46edda13 /drivers/net/ethernet/xircom/xirc2ps_cs.c | |
| parent | 25143b6a01d0cc5319edd3de22ffa2578b045550 (diff) | |
| download | linux-e8d20c3ded59a092532513c9bd030d1ea66f5f44.tar.xz | |
xirc2ps_cs: Fix use after free bug in xirc2ps_detach
In xirc2ps_probe, the local->tx_timeout_task was bounded
with xirc2ps_tx_timeout_task. When timeout occurs,
it will call xirc_tx_timeout->schedule_work to start the
work.
When we call xirc2ps_detach to remove the driver, there
may be a sequence as follows:
Stop responding to timeout tasks and complete scheduled
tasks before cleanup in xirc2ps_detach, which will fix
the problem.
CPU0 CPU1
|xirc2ps_tx_timeout_task
xirc2ps_detach |
free_netdev |
kfree(dev); |
|
| do_reset
| //use dev
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/xircom/xirc2ps_cs.c')
| -rw-r--r-- | drivers/net/ethernet/xircom/xirc2ps_cs.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/ethernet/xircom/xirc2ps_cs.c b/drivers/net/ethernet/xircom/xirc2ps_cs.c index 894e92ef415b..9f505cf02d96 100644 --- a/drivers/net/ethernet/xircom/xirc2ps_cs.c +++ b/drivers/net/ethernet/xircom/xirc2ps_cs.c @@ -503,6 +503,11 @@ static void xirc2ps_detach(struct pcmcia_device *link) { struct net_device *dev = link->priv; + struct local_info *local = netdev_priv(dev); + + netif_carrier_off(dev); + netif_tx_disable(dev); + cancel_work_sync(&local->tx_timeout_task); dev_dbg(&link->dev, "detach\n"); |